Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/19078#discussion_r135950507
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/feature/PCA.scala ---
@@ -44,6 +44,14 @@ class PCA @Since("1.4.0") (@Since("1.4.0") val k: Int) {
require(k <= numFeatures,
s"source vector size $numFeatures must be no less than k=$k")
+ val workSize = ( 3
+ * math.min(k, numFeatures) * math.min(k, numFeatures)
+ + math.max(math.max(k, numFeatures), 4 * math.min(k, numFeatures)
+ * math.min(k, numFeatures) + 4 * math.min(k, numFeatures))
+ )
+ require(workSize <= Int.MaxValue,
+ "The param K and numFeatures is too large for SVD computation.")
--- End diff --
"K" -> "k"
I'd also add this to be super-explicit: "Try reducing the parameter k for
PCA, or reduce the input feature vector dimension to make this tractable."
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
