Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18787#discussion_r135952996
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/arrow/ArrowConvertersSuite.scala
---
@@ -1629,6 +1632,39 @@ class ArrowConvertersSuite extends SharedSQLContext
with BeforeAndAfterAll {
}
}
+ test("roundtrip payloads") {
+ val allocator = ArrowUtils.rootAllocator.newChildAllocator("int", 0,
Long.MaxValue)
+ val vector = ArrowUtils.toArrowField("int", IntegerType, nullable =
true)
+ .createVector(allocator).asInstanceOf[NullableIntVector]
+ vector.allocateNew()
+ val mutator = vector.getMutator()
+
+ (0 until 10).foreach { i =>
+ mutator.setSafe(i, i)
+ }
+ mutator.setNull(10)
+ mutator.setValueCount(11)
+
+ val schema = StructType(Seq(StructField("int", IntegerType)))
+
+ val batch = new ColumnarBatch(schema, Array[ColumnVector](new
ArrowColumnVector(vector)), 11)
--- End diff --
Yes, I meant your second comment.
We do test the columnar batch with `ArrowColumnVector` in
`ColumnarBatchSuite` and also we use it in
`ArrowConverters.fromPayloadIterator()`, so I thought we don't need to use it
here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
