Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18270#discussion_r136121931
  
    --- Diff: 
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala 
---
    @@ -1414,6 +1414,19 @@ class SQLQuerySuite extends QueryTest with 
SQLTestUtils with TestHiveSingleton {
           ).map(i => Row(i._1, i._2, i._3)))
       }
     
    +  test("SPARK-21055 replace grouping__id: Wrong Result for Rollup #1") {
    --- End diff --
    
    Instead of adding a new one, you can just make a change on the existing 
one. 
    ```Scala
      test("SPARK-8976 Wrong Result for Rollup #1") {
        Seq("grouping_id()", "grouping__id").foreach { gid =>
          checkAnswer(sql(
            s"SELECT count(*) AS cnt, key % 5, $gid FROM src GROUP BY key%5 
WITH ROLLUP"),
            Seq(
              (113, 3, 0),
              (91, 0, 0),
              (500, null, 1),
              (84, 1, 0),
              (105, 2, 0),
              (107, 4, 0)
            ).map(i => Row(i._1, i._2, i._3)))
        }
      }
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to