Github user 10110346 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19077#discussion_r136223648
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/memory/HeapMemoryAllocator.java
---
@@ -47,23 +47,29 @@ private boolean shouldPool(long size) {
@Override
public MemoryBlock allocate(long size) throws OutOfMemoryError {
- if (shouldPool(size)) {
+ int arraySize = (int)((size + 7) / 8);
+ long alignedSize = arraySize * 8;
+ if (shouldPool(alignedSize)) {
synchronized (this) {
- final LinkedList<WeakReference<MemoryBlock>> pool =
bufferPoolsBySize.get(size);
+ final LinkedList<WeakReference<MemoryBlock>> pool =
bufferPoolsBySize.get(alignedSize);
if (pool != null) {
while (!pool.isEmpty()) {
final WeakReference<MemoryBlock> blockReference = pool.pop();
final MemoryBlock memory = blockReference.get();
if (memory != null) {
- assert (memory.size() == size);
+ assert ((int)((memory.size() + 7) / 8) == arraySize);
+ memory.resetSize(size);
--- End diff --
yes, `MemoryBlock` is always the actual size, if we reuse the previous
memory,we should modify the size of `MemoryBlock`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
