Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19100#discussion_r136473016
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/OptimizeMetadataOnlyQuerySuite.scala
 ---
    @@ -117,4 +117,12 @@ class OptimizeMetadataOnlyQuerySuite extends QueryTest 
with SharedSQLContext {
         "select partcol1, max(partcol2) from srcpart where partcol1 = 0 group 
by rollup (partcol1)",
         "select partcol2 from (select partcol2 from srcpart where partcol1 = 0 
union all " +
           "select partcol2 from srcpart where partcol1 = 1) t group by 
partcol2")
    +
    +  test("SPARK-21884 Fix StackOverflowError on MetadataOnlyQuery") {
    --- End diff --
    
    Here, just add a test case from https://github.com/apache/spark/pull/19094 
for verifying the fix in https://github.com/apache/spark/pull/18686


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to