Github user jinxing64 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19086#discussion_r136719337
  
    --- Diff: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
    @@ -502,17 +502,16 @@ private[spark] class HiveExternalCatalog(conf: 
SparkConf, hadoopConf: Configurat
         val storageWithNewPath = if (rawTable.tableType == MANAGED && 
hasPathOption) {
           // If it's a managed table with path option and we are renaming it, 
then the path option
           // becomes inaccurate and we need to update it according to the new 
table name.
    -      val newTablePath = defaultTablePath(TableIdentifier(newName, 
Some(db)))
    +      val newTablePath = defaultTablePath(TableIdentifier(newName, 
Some(newDb)))
    --- End diff --
    
    
https://github.com/apache/spark/pull/19086/files#diff-8c4108666a6639034f0ddbfa075bcb37R827
    Is this ok?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to