Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/2241#discussion_r18430262
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/TestHive.scala
---
@@ -78,6 +79,7 @@ class TestHiveContext(sc: SparkContext) extends
HiveContext(sc) {
// For some hive test case which contain ${system:test.tmp.dir}
System.setProperty("test.tmp.dir", testTempDir.getCanonicalPath)
+ CommandProcessorFactory.clean(hiveconf)
--- End diff --
Since it is a cleanup work, seems it is better to be placed after
`System.clearProperty("spark.hostPort")`. Also, please add comment about what
this call is doing and why it is needed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
