Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/18253
I really dislike `WithListenerBus` - both as a name and as a concept.
There's already a `ListenerBus` trait; if it's not enough or is broken in some
way, it should be fixed, instead of being patched by introducing yet more
complexity in the hierarchy.
I think part of the confusion here is that the current code is trying to
both refactor the `ListenerBus` hierarchy and add the concept of queues are the
same time. From my point of view they're different things and could be done
separately. For example you could add queues to `LiveListenerBus` only, which
is really the only place that matters in the end. Maybe it won't be optimal in
its first iteration, but it would be a much easier change to review.
I don't doubt that there's benefit in taking a holistic look into this part
of the class hierarchy; but it would be good to do that separately, both so
that we can clearly see that the proposed hierarchy makes sense, and so that
it's easier to review things. It's easier to wrap your head around the code if
it's focused on one problem instead of two.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
