Github user holdenk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18339#discussion_r137360888
  
    --- Diff: python/pyspark/java_gateway.py ---
    @@ -33,14 +33,18 @@
     from pyspark.serializers import read_int
     
     
    -def launch_gateway(conf=None):
    +def launch_gateway(conf=None, popen_kwargs=None):
    --- End diff --
    
    I'd make this _popen_kwargs to indicate it's usage is possibly not super 
supported.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to