Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r137918931
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -360,6 +360,31 @@ case class InsertIntoTable(
}
/**
+ * Insert query result into a directory.
+ *
+ * @param isLocal Indicates whether the specified directory is local
directory
+ * @param storage Info about output file, row and what serialization format
+ * @param provider Specifies what data source to use; only used for data
source file.
+ * @param child The query to be executed
+ * @param overwrite If true, the existing directory will be overwritten
+ *
+ * Note that this plan is unresolved and has to be replaced by the
concrete implementations
+ * during analysis.
+ */
+case class InsertIntoDir(
+ isLocal: Boolean,
+ storage: CatalogStorageFormat,
+ provider: Option[String],
+ child: LogicalPlan,
+ overwrite: Boolean = true)
+ extends LogicalPlan {
+
+ override def children: Seq[LogicalPlan] = child :: Nil
--- End diff --
Nit: We can simply extend `UnaryNode` and remove `children`.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
