Github user goldmedal commented on a diff in the pull request: https://github.com/apache/spark/pull/18875#discussion_r137978096 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala --- @@ -677,14 +696,27 @@ case class StructsToJson( override def checkInputDataTypes(): TypeCheckResult = child.dataType match { case _: StructType | ArrayType(_: StructType, _) => try { - JacksonUtils.verifySchema(rowSchema) + JacksonUtils.verifySchema(rowSchema.asInstanceOf[StructType]) + TypeCheckResult.TypeCheckSuccess + } catch { + case e: UnsupportedOperationException => + TypeCheckResult.TypeCheckFailure(e.getMessage) + } + case ArrayType(_: MapType, _) => + TypeCheckResult.TypeCheckSuccess + case MapType(_: DataType, st: StructType, _: Boolean) => + try { + JacksonUtils.verifySchema(st) TypeCheckResult.TypeCheckSuccess } catch { case e: UnsupportedOperationException => TypeCheckResult.TypeCheckFailure(e.getMessage) } + case _: MapType => --- End diff -- @viirya But the `JacksonUtils.verifySchema` only verify a `StructType`, so we need to add a new one?
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org