Github user kiszk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19188#discussion_r138009182
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/TPCDSQueryBenchmark.scala
 ---
    @@ -113,12 +114,40 @@ object TPCDSQueryBenchmark {
           "q81", "q82", "q83", "q84", "q85", "q86", "q87", "q88", "q89", "q90",
           "q91", "q92", "q93", "q94", "q95", "q96", "q97", "q98", "q99")
     
    +    val sparkConf = new SparkConf()
    +      .setMaster("local[1]")
    +      .setAppName("test-sql-context")
    +      .set("spark.sql.parquet.compression.codec", "snappy")
    +      .set("spark.sql.shuffle.partitions", "4")
    +      .set("spark.driver.memory", "3g")
    +      .set("spark.executor.memory", "3g")
    +      .set("spark.sql.autoBroadcastJoinThreshold", (20 * 1024 * 
1024).toString)
    +      .set("spark.sql.crossJoin.enabled", "true")
    +
    +    // If `spark.sql.tpcds.queryFilter` defined, this class filters the 
queries that
    --- End diff --
    
    nit: `class` -> `variable`?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to