Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19185#discussion_r138045280
--- Diff: python/pyspark/ml/classification.py ---
@@ -529,8 +529,11 @@ def summary(self):
"""
if self.hasSummary:
java_blrt_summary = self._call_java("summary")
- # Note: Once multiclass is added, update this to return
correct summary
- return
BinaryLogisticRegressionTrainingSummary(java_blrt_summary)
+ if (self.numClasses == 2):
+ java_blrt_binarysummary = self._call_java("binarySummary")
--- End diff --
Actually this is not necessary, we can just wrap ```java_lrt_summary```
with ```BinaryLogisticRegressionTrainingSummary```.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
