GitHub user liancheng opened a pull request:

    https://github.com/apache/spark/pull/2675

    [3809][SQL] Fixes test suites in hive-thriftserver

    As @scwf pointed out, `HiveThriftServer2Suite` isn't effective anymore 
after the Thrift server was made a daemon. On the other hand, these test suites 
were known flaky, PR #2214 tried to fix them but failed because of unknown 
Jenkins build error. This PR is another try to fix both issue.
    
    In this PR, instead of watching `start-thriftserver.sh` output, the test 
code start a `tail` process to watch the log file. A `Thread.sleep` has to be 
introduced because the `kill` command used in `stop-thriftserver.sh` is not 
synchronous.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/liancheng/spark fix-thriftserver-tests

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/2675.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2675
    
----
commit 5094bb446922875b41bfaf06fc54510d6ef9b22e
Author: Cheng Lian <lian.cs....@gmail.com>
Date:   2014-10-06T14:15:21Z

    Fixes test suites in hive-thriftserver

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to