Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/19181#discussion_r138733553
--- Diff:
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorter.java
---
@@ -85,7 +85,7 @@
private final LinkedList<UnsafeSorterSpillWriter> spillWriters = new
LinkedList<>();
// These variables are reset after spilling:
- @Nullable private volatile UnsafeInMemorySorter inMemSorter;
+ @VisibleForTesting @Nullable volatile UnsafeInMemorySorter inMemSorter;
--- End diff --
This is slightly hair raising. Can you try to find a different - less
tricky path - to test this?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
