Github user tdas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19196#discussion_r138772306
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/streaming/FlatMapGroupsWithStateSuite.scala
 ---
    @@ -873,6 +875,96 @@ class FlatMapGroupsWithStateSuite extends 
StateStoreMetricsTest with BeforeAndAf
         assert(e.getMessage === "The output mode of function should be append 
or update")
       }
     
    +  test("SPARK-21977: coalesce(1) should still be repartitioned when it has 
keyExpressions") {
    --- End diff --
    
    what changed code paths this test cover that is not already covered by the 
other tests you added.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to