Github user jerryshao commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19210#discussion_r138879962
  
    --- Diff: 
core/src/main/scala/org/apache/spark/metrics/sink/GraphiteSink.scala ---
    @@ -69,7 +69,7 @@ private[spark] class GraphiteSink(val property: 
Properties, val registry: Metric
     
       val graphite = 
propertyToOption(GRAPHITE_KEY_PROTOCOL).map(_.toLowerCase(Locale.ROOT)) match {
         case Some("udp") => new GraphiteUDP(new InetSocketAddress(host, port))
    -    case Some("tcp") | None => new Graphite(new InetSocketAddress(host, 
port))
    +    case Some("tcp") | None => new Graphite(host, port)
    --- End diff --
    
    Do we need to change here also?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to