Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19211#discussion_r139180525
  
    --- Diff: 
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
    @@ -217,7 +217,7 @@ private[spark] class ExecutorAllocationManager(
        * the scheduling task.
        */
       def start(): Unit = {
    -    listenerBus.addListener(listener)
    +    listenerBus.addToQueue(listener, LiveListenerBus.EXECUTOR_MGMT_QUEUE)
    --- End diff --
    
    will we have more queues in the future? If it's not too many, maybe we can 
use different methods, like `addToMGMTQueue`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to