Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18887#discussion_r139467580
--- Diff:
core/src/test/scala/org/apache/spark/deploy/history/FsHistoryProviderSuite.scala
---
@@ -624,7 +639,9 @@ class FsHistoryProviderSuite extends SparkFunSuite with
BeforeAndAfter with Matc
}
private def createTestConf(): SparkConf = {
- new SparkConf().set("spark.history.fs.logDirectory",
testDir.getAbsolutePath())
+ new SparkConf()
+ .set("spark.history.fs.logDirectory", testDir.getAbsolutePath())
+ .set(LOCAL_STORE_DIR, Utils.createTempDir().getAbsolutePath())
--- End diff --
The `kvstore` module already tests both in-memory and disk stores
extensively (running the same set of tests on both). There isn't really
anything that testing both here can add to those tests.
At most I could make `FsHistoryProvider` do round-robin between disk and
in-memory; but I don't see the point of running these tests twice.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
