[GitHub] spark pull request #19270: [SPARK-21809] : Change Stage Page to use datatabl...

[pgandhi999]

GitHub user pgandhi999 opened a pull request:

    https://github.com/apache/spark/pull/19270

    [SPARK-21809] : Change Stage Page to use datatables to support sorting 
columns and searching

    Support column sort and search for Stage Server using jQuery DataTable and 
REST API. Before this commit, the Stage page was generated hard-coded HTML and 
can not support search, also, the sorting was disabled if there is any 
application that has more than one attempt. Supporting search and sort (over 
all applications rather than the 20 entries in the current page) in any case 
will greatly improve the user experience.
    Created the stagespage-template.html for displaying application information 
in datables. Added REST api endpoint and javascript code to fetch data from the 
endpoint and display it on the data table.
    Because of the above change, certain functionalities in the page had to be 
modified to support the addition of datatables. For example, the toggle 
checkbox 'Select All' previously would add the checked fields as columns in the 
Task table and as rows in the Summary Metrics table, but after the change, only 
columns are added in the Task Table as it got tricky to add rows dynamically in 
the datatables.
    
    ## How was this patch tested?
    I have attached the screenshots of the Stage Page UI before and after the 
fix.
    Before:
    <img width="1419" alt="screen shot-before" 
src="https://user-images.githubusercontent.com/22228190/30564304-35991e1c-9c8a-11e7-850f-2ac7a347f600.png";>
    After:
    <img width="1423" alt="screen shot- after" 
src="https://user-images.githubusercontent.com/22228190/30564335-4c558c8a-9c8a-11e7-93f1-a5b9dbdc8f4c.png";>


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pgandhi999/spark SPARK-21809

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/19270.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #19270
    
----
commit 01c9244d1a2d4aac69cd7b0d2535ce65ae62ce08
Author: pgandhi <pgan...@yahoo-inc.com>
Date:   2017-09-12T14:06:22Z

    [SPARK-21809] : Change Stage Page to use datatables to support sorting 
columns and searching
    
    Converted static html tables to datatables on stage page
    
    [SPARK-21809] : Change Stage Page to use datatables to support sorting 
columns and searching

commit 4b94bc0c25322b26207201a4dd30a17d7d8fca39
Author: pgandhi <pgan...@yahoo-inc.com>
Date:   2017-09-12T15:21:12Z

    [SPARK-21809] : Fixing code to pass ScalaStyle Tests
    
    [SPARK-21809] : Fixing code to pass ScalaStyle Check

commit c58895357d568b5980a8cda7420536c3d87af4c5
Author: pgandhi <pgan...@yahoo-inc.com>
Date:   2017-09-13T20:25:15Z

    [SPARK-21809] : Adding new fields at the end of constructor definition

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org