Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/19181#discussion_r139570073 --- Diff: core/src/test/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorterSuite.java --- @@ -503,6 +511,39 @@ public void testGetIterator() throws Exception { verifyIntIterator(sorter.getIterator(279), 279, 300); } + @Test + public void testOOMDuringSpill() throws Exception { + final UnsafeExternalSorter sorter = newSorter(); + for (int i = 0; sorter.hasSpaceForAnotherRecord(); ++i) { --- End diff -- Will this make the test case takes quite a long time to finish?
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org