GitHub user WeichenXu123 opened a pull request:
https://github.com/apache/spark/pull/19278
[SPARK-22060][ML] Fix CrossValidator/TrainValidationSplit param
persist/load bug
## What changes were proposed in this pull request?
Currently the param of CrossValidator/TrainValidationSplit persist/loading
is hardcoding, which is different with other ML estimators. This cause persist
bug for new added `parallelism` param.
I refactor related code, avoid hardcoding persist/load param. And in the
same time, it solve the `parallelism` persisting bug.
This refactoring is very useful because we will add more new params in
#19208 , hardcoding param persisting/loading making the thing adding new params
very troublesome.
## How was this patch tested?
Test added.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/WeichenXu123/spark fix-tuning-param-bug
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/19278.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #19278
----
commit 042b3d586ad480dee22cbbdab8f4efd4e1ab1de4
Author: WeichenXu <weichen...@databricks.com>
Date: 2017-09-19T13:12:42Z
init pr
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
