GitHub user viirya opened a pull request:

    https://github.com/apache/spark/pull/19286

    [SPARK-21338][SQL][FOLLOW-UP] Implement isCascadingTruncateTable() method 
in AggregatedDialect

    ## What changes were proposed in this pull request?
    
    The implemented `isCascadingTruncateTable` in `AggregatedDialect` is wrong. 
When no dialect claims cascading, once there is an unknown cascading truncate 
in the dialects, we should return unknown cascading, instead of false.
    
    ## How was this patch tested?
    
    Added test.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/viirya/spark-1 SPARK-21338-followup

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/19286.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #19286
    
----
commit 803b1961a34d4d9f4c8ebcbe5544dd23fbaa720a
Author: Liang-Chi Hsieh <vii...@gmail.com>
Date:   2017-09-20T04:52:08Z

    Fix isCascadingTruncateTable for AggregatedDialect.

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to