Github user zuotingbing commented on the issue:

    https://github.com/apache/spark/pull/19277
  
    I am not sure. If we move this line `val in = new 
BufferedInputStream(fs.open(log))` into try~catch, we should define `var in: 
BufferedInputStream = null` before, and use `catch { case e: Exception => if 
(in != null) { in.close() in = null } throw e }` to close the 
BufferedInputStream when exception occurs. It is more complex, so i would like 
the code before.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to