Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/19294#discussion_r140342523
--- Diff:
core/src/main/scala/org/apache/spark/internal/io/HadoopMapReduceCommitProtocol.scala
---
@@ -57,6 +57,11 @@ class HadoopMapReduceCommitProtocol(jobId: String, path:
String)
*/
private def absPathStagingDir: Path = new Path(path, "_temporary-" +
jobId)
+ /**
+ * Checks whether there are files to be committed to an absolute output
location.
+ */
+ private def hasAbsPathFiles: Boolean = addedAbsPathFiles != null &&
addedAbsPathFiles.nonEmpty
--- End diff --
When addedAbsPathFiles is null and when it is not is slightly confusing.
Can we move to using an Option[Map[String, String]] instead ?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
