Github user juliuszsompolski commented on the issue:
https://github.com/apache/spark/pull/19324
@viirya This is related to https://github.com/apache/spark/pull/18931/, as
it also separates out the consume function. Maybe it would be enough to do
similar splits into functions in the codegen of some operators that are
materialization points (sort, joins) to keep the function length in check?
Splitting out on every `consume` takes away some of compiler's
opportunities to optimize, like e.g. delaying evaluation of some projection
(which you mentioned in your PR).
Removing the use of `continue` also simplifies not needing to handle it in
your PR.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
