Github user jinxing64 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19330#discussion_r140627825
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -663,6 +663,18 @@ class CodegenContext {
}
"""
s"${addNewFunction(compareFunc, funcCode)}($c1, $c2)"
+ case map: MapType =>
+ val compareFunc = freshName("compareMap")
+ val compare = this.addReferenceObj("compare",
map.interpretedOrdering,
+ classOf[Ordering[MapData]].getCanonicalName)
--- End diff --
TODO: we should code generate this.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
