Github user HyukjinKwon commented on the issue:

    https://github.com/apache/spark/pull/19290
  
    > 5 min: this is mildly concerning, is it possible this is caused by new 
checks in lintr? perhaps we could exclude them or something?
    
    1.0.1 miss the linters below (vs master):
    
    ```
    nonportable_path_linter: check that file.path() is used to construct safe 
and portable paths.
    pipe_continuation_linter: Check that each step in a pipeline is on a new 
line, or the entire pipe fits on one line.
    extraction_operator_linter: check that the [[ operator is used when 
extracting a single element from an object, not [ (subsetting) nor $ 
(interactive use).
    implicit_integer_linter: check that integers are explicitly typed using the 
form 1L instead of 1.
    object_name_linter: check that object names conform to a single naming 
style, e.g. snake_case or lowerCamelCase.
    semicolon_terminator_linter: check that no semicolons terminate statements.
    todo_comment_linter: check that the source contains no TODO comments 
(case-insensitive).
    T_and_F_symbol_linter: avoid the symbols T and F (for TRUE and FALSE).
    undesirable_function_linter: report the use of undesirable functions, e.g. 
options or sapply and suggest an alternative.
    undesirable_operator_linter: report the use of undesirable operators, e.g. 
::: or <<- and suggest an alternative.
    unneeded_concatenation_linter: check that the c function is not used 
without arguments nor with a single constant
    ```
    
    I manually disabled the linters above but the elapsed time looks almost the 
same. So, I think some existing linters were slowed down in the master - I 
tried to disable everything except for each linter - 
https://gist.github.com/HyukjinKwon/1f852bcdcc2a13f396dfd2d6a88bea16


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to