Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19286#discussion_r140638171
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/AggregatedDialect.scala ---
@@ -43,6 +43,17 @@ private class AggregatedDialect(dialects:
List[JdbcDialect]) extends JdbcDialect
}
override def isCascadingTruncateTable(): Option[Boolean] = {
- dialects.flatMap(_.isCascadingTruncateTable()).reduceOption(_ || _)
+ // If any dialect claims cascading truncate, this dialect is also
cascading truncate.
+ // Otherwise, if any dialect has unknown cascading truncate, this
dialect is also unknown.
+ val cascading =
dialects.flatMap(_.isCascadingTruncateTable()).reduceOption(_ || _)
+ if (cascading.getOrElse(false)) {
--- End diff --
Use case-match?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
