Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19370#discussion_r141532178
  
    --- Diff: bin/run-example.cmd ---
    @@ -17,6 +17,13 @@ rem See the License for the specific language governing 
permissions and
     rem limitations under the License.
     rem
     
    -set SPARK_HOME=%~dp0..
    +rem Figure out where the Spark framework is installed
    +set FIND_SPARK_HOME_SCRIPT=%~dp0find_spark_home.py
    +if exist "%FIND_SPARK_HOME_SCRIPT%" (
    +  for /f %%i in ('python %FIND_SPARK_HOME_SCRIPT%') do set SPARK_HOME=%%i
    --- End diff --
    
    I'm not sure if python would be the right one (python2, python3, is it in 
PATH)?
    and I don't think `cmd /c foo.py` works either


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to