Github user nzw0301 commented on the issue:

    https://github.com/apache/spark/pull/19372
  
    Thank you for your comment, @LowikC.
    You are right, my PR code is incorrect.
    
    Correct update formula is
    
    ```scala
    alpha = learningRate *
      (1 - numPartitions * wordCount.toDouble + (k - 1) * trainWordsCount /
        (numIterations * trainWordsCount + 1))
    ```



---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to