Github user superbobry commented on a diff in the pull request:
https://github.com/apache/spark/pull/19369#discussion_r141672528
--- Diff: core/src/main/scala/org/apache/spark/storage/DiskStore.scala ---
@@ -67,7 +67,7 @@ private[spark] class DiskStore(
var threwException: Boolean = true
try {
writeFunc(out)
- blockSizes.put(blockId.name, out.getCount)
+ blockSizes.put(blockId, out.getCount)
--- End diff --
This is in line with the other part of the PR: `name` allocates a
String/StringBuilder. Why use it as a hash key and pay the price of unnecessary
allocation, when `BlockId` is hashable?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
