Github user HyukjinKwon commented on the issue:

    https://github.com/apache/spark/pull/19389
  
    > why the tests are all going into `ParquetPartitionDiscoverySuite` -- this 
doesn't seem specific to parquet, and in fact I wonder if it will be different 
in parquet since the non-partition columns have schemas specified in the data. 
I'm just surprised this isn't tested across more formats.
    
    Yea, I agree since this problem is not specific to Parquet. Here, such 
changes and test cases look added in this file so far and I simply just decided 
to follow it, rather than including changes here restructuing or moving the 
test cases, partly for the easy of backporting (we should backport this into 
branch-2.2 and 2.1) and partly to reduce reviewing cost.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to