Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19401#discussion_r142003100
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -238,8 +238,9 @@ class Dataset[T] private[sql](
private[sql] def showString(
_numRows: Int, truncate: Int = 20, vertical: Boolean = false):
String = {
val numRows = _numRows.max(0)
- val takeResult = toDF().take(numRows + 1)
- val hasMoreData = takeResult.length > numRows
+ val numTotalRows = toDF().count()
--- End diff --
In the suggested, `hasMoreData` gets meaningless, so how about this?;
```
val (data, hasMoreData) = if (numRows < Int.MaxValue) {
val takeResult = toDF().take(numRows + 1)
(takeResult.take(numRows), takeResult.length > numRows)
} else {
val takeResult = toDF().take(numRows)
val numTotalRows = toDF().count()
(takeResult.take(numRows), numTotalRows > numRows)
}
```
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
