Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17819#discussion_r142278563
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -2120,6 +2120,19 @@ class Dataset[T] private[sql](
}
/**
+ * Returns a new Dataset by adding columns with metadata.
+ */
+ private[spark] def withColumns(
+ colNames: Seq[String],
+ cols: Seq[Column],
+ metadata: Seq[Metadata]): DataFrame = {
+ val newCols = colNames.zip(cols).zip(metadata).map { case ((colName,
col), metadata) =>
--- End diff --
Is that possible the number of elements in metadata do not match? Then, the
results will be unexpected because of this impl
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
