Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19416#discussion_r142303228
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/FlatMapGroupsWithStateSuite.scala
---
@@ -397,50 +435,23 @@ class FlatMapGroupsWithStateSuite extends
StateStoreMetricsTest with BeforeAndAf
timeoutConf = EventTimeTimeout,
priorState = priorState,
priorTimeoutTimestamp = priorTimeoutTimestamp,
- expectedState = Some(5), // state
should change
- expectedTimeoutTimestamp = NO_TIMESTAMP) //
timestamp should not update
- }
- }
-
- // Currently disallowed cases for
StateStoreUpdater.updateStateForKeysWithData(),
- // Try to remove these cases in the future
- for (priorTimeoutTimestamp <- Seq(NO_TIMESTAMP, 1000)) {
--- End diff --
These functions test the cases where exception used to thrown to avoid null
state + timeout to be saved. The exception checks have now been replaced by the
correct output tests (see the added lines above).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
