GitHub user rekhajoshm opened a pull request: https://github.com/apache/spark/pull/19418
[SPARK-19984][SQL] Fix for ERROR codegen.CodeGenerator: failed to compile: org.codehaus.commons.compiler.CompileException: for generated java file ## What changes were proposed in this pull request? From the erratic error observed and quick analysis of code, it seems like leftKeys(i).dataType in SortMergeJoinExec is an AtomicType.It also seems that casting/promotion have played a role, as variable gets reported as long, but does not match the expected case flow of primitives {code} case dt: DataType if isPrimitiveType(dt) => s"($c1 > $c2 ? 1 : $c1 < $c2 ? -1 : 0)" {code} The fix is to not invoke compare if method does not exist. ## How was this patch tested? existing test Please review http://spark.apache.org/contributing.html before opening a pull request. You can merge this pull request into a Git repository by running: $ git pull https://github.com/rekhajoshm/spark SPARK-19984 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/19418.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #19418 ---- commit e3677c9fa9697e0d34f9df52442085a6a481c9e9 Author: Rekha Joshi <rekhajo...@gmail.com> Date: 2015-05-05T23:10:08Z Merge pull request #1 from apache/master Pulling functionality from apache spark commit 106fd8eee8f6a6f7c67cfc64f57c1161f76d8f75 Author: Rekha Joshi <rekhajo...@gmail.com> Date: 2015-05-08T21:49:09Z Merge pull request #2 from apache/master pull latest from apache spark commit 0be142d6becba7c09c6eba0b8ea1efe83d649e8c Author: Rekha Joshi <rekhajo...@gmail.com> Date: 2015-06-22T00:08:08Z Merge pull request #3 from apache/master Pulling functionality from apache spark commit 6c6ee12fd733e3f9902e10faf92ccb78211245e3 Author: Rekha Joshi <rekhajo...@gmail.com> Date: 2015-09-17T01:03:09Z Merge pull request #4 from apache/master Pulling functionality from apache spark commit b123c601e459d1ad17511fd91dd304032154882a Author: Rekha Joshi <rekhajo...@gmail.com> Date: 2015-11-25T18:50:32Z Merge pull request #5 from apache/master pull request from apache/master commit c73c32aadd6066e631956923725a48d98a18777e Author: Rekha Joshi <rekhajo...@gmail.com> Date: 2016-03-18T19:13:51Z Merge pull request #6 from apache/master pull latest from apache spark commit 7dbf7320057978526635bed09dabc8cf8657a28a Author: Rekha Joshi <rekhajo...@gmail.com> Date: 2016-04-05T20:26:40Z Merge pull request #8 from apache/master pull latest from apache spark commit 5e9d71827f8e2e4d07027281b80e4e073e7fecd1 Author: Rekha Joshi <rekhajo...@gmail.com> Date: 2017-05-01T23:00:30Z Merge pull request #9 from apache/master Pull apache spark commit 63d99b3ce5f222d7126133170a373591f0ac67dd Author: Rekha Joshi <rekhajo...@gmail.com> Date: 2017-09-30T22:26:44Z Merge pull request #10 from apache/master pull latest apache spark commit 0fa4d6154a4fe9d46c020dc979a0a835776cd83d Author: rjoshi2 <rekhajo...@gmail.com> Date: 2017-10-03T04:40:53Z [SPARK-19984][SQL] Fix for ERROR codegen.CodeGenerator: failed to compile: org.codehaus.commons.compiler.CompileException: for generated java file ---- --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org