Github user srowen commented on the issue:

    https://github.com/apache/spark/pull/19406
  
    Your new test also passes when changing ...
    
    ```
        val targetError = relativeError * count
    ...
        var i = 0
    ```
    
    I think this is more likely to be the correct fix as it matches the paper 
and isn't just patching the case of the first element.
    
    It does make another test fail, just barely -- seems still within 
tolerances.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to