Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19083#discussion_r142503203
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -1020,10 +1006,14 @@ abstract class CodeGenerator[InType <: AnyRef,
OutType <: AnyRef] extends Loggin
}
object CodeGenerator extends Logging {
+
+ // This is the value of HugeMethodLimit in the OpenJDK JVM settings
+ val DEFAULT_JVM_HUGE_METHOD_LIMIT = 8000
+
/**
* Compile the Java source code into a Java class, using Janino.
*/
- def compile(code: CodeAndComment): GeneratedClass = try {
+ def compile(code: CodeAndComment): (GeneratedClass, Int) = try {
--- End diff --
Please add `@return` to explain what are returned.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
