Github user akopich commented on the issue:
https://github.com/apache/spark/pull/18924
@jkbradley, thank you!
- Correctness: in order to test the equivalence of two versions of
`submitMiniBatch` I have to bring both of them into the scope... One solution
would be to derive a class `OldOnlineLDAOptimizer` from `OnlineLDAOptimizer`
and override `submitMiniBatch` but the class is final. What's the preferred
approach?
- Sure. Sounds good. Should I add test-case reporting the CPU time or
should I rather define an `App`? Should I add the code to the PR or just report
the results here?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
