Github user icexelloss commented on a diff in the pull request:
https://github.com/apache/spark/pull/18732#discussion_r142957552
--- Diff: python/pyspark/sql/functions.py ---
@@ -2058,7 +2058,7 @@ def __init__(self, func, returnType, name=None,
vectorized=False):
self._name = name or (
func.__name__ if hasattr(func, '__name__')
else func.__class__.__name__)
- self._vectorized = vectorized
+ self.vectorized = vectorized
--- End diff --
Are we ok with having `vectorized` being public field? I am fine with both
public or private but I do think the fields of the function returned by
`UserDefinedFuncion_wrapped()` should have the same field names as
`UserDefinedFunction` to avoid confusion.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
