Github user kiszk commented on the issue:

    https://github.com/apache/spark/pull/19447
  
    @mgaido91 When I reduced this value to 10000, [this test 
case](https://github.com/apache/spark/pull/16648/files#diff-c7f041fda7fd9aa1a5225f86bab4b1b0R69)
 causes an exception `JVM limit of 0xFFFF`. Unfortunately, my proposal to watch 
# of `CodegenContext.mutableStates` did not work, too. This is because to 
generate nested classes does not reduce the number of instance variables (more 
than 64000 in this test case) in the top class.
    
    I would appreciate it if you would double-check this to avoid possibility 
of my mistake. If you could not find this PR can help [this test 
case](https://github.com/apache/spark/pull/16648/files#diff-c7f041fda7fd9aa1a5225f86bab4b1b0R69),
 could you please clarify what cases can be resolved by this PR by using test 
cases? Then, we can discuss whether this PR would be useful for users or not.
    
    What do you think?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to