Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/19419#discussion_r143349235
--- Diff: conf/spark-defaults.conf.template ---
@@ -25,3 +25,10 @@
# spark.serializer
org.apache.spark.serializer.KryoSerializer
# spark.driver.memory 5g
# spark.executor.extraJavaOptions -XX:+PrintGCDetails -Dkey=value
-Dnumbers="one two three"
+
+# spark.ui.allowFramingFrom https://www.example.com/
--- End diff --
Hm, my last thought on this is that these are undocumented options, and
maybe rightly so as they're kind of advanced options. But if so they don't
really have a place in the default props template; what do they mean to a user?
I think they should actually be removed here, on second glance, but,
wouldn't be a big deal to document them in the configuration doc as they're
arguably non-internal, important functionality for some users.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
