Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/19438#discussion_r143480931 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/QuantileSummariesSuite.scala --- @@ -58,7 +58,7 @@ class QuantileSummariesSuite extends SparkFunSuite { if (data.nonEmpty) { val approx = summary.query(quant).get // The rank of the approximation. - val rank = data.count(_ < approx) // has to be <, not <= to be exact + val rank = data.count(_ <= approx) --- End diff -- In one of the test case, `data.count(_ < approx)` = 39 and `data.count(_ <= approx)` = 40, so the average (39 + 40) / 2 < 40 (lower bound), the test still fails. Besides, data in the test suite is increasing/decreasing/random, so the case [1,2,2,2,2,2,2,2,3] can hardly happen.
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org