Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19437#discussion_r143571471
--- Diff:
resource-managers/mesos/src/test/scala/org/apache/spark/scheduler/cluster/mesos/Utils.scala
---
@@ -105,4 +108,108 @@ object Utils {
def createTaskId(taskId: String): TaskID = {
TaskID.newBuilder().setValue(taskId).build()
}
+
+ def configEnvBasedRefSecrets(secretConfig: MesosSecretConfig):
Map[String, String] = {
+ val secretName = "/path/to/secret,/anothersecret"
+ val envKey = "SECRET_ENV_KEY,PASSWORD"
+ Map(
+ secretConfig.SECRET_NAME.key -> secretName,
+ secretConfig.SECRET_ENVKEY.key -> envKey
+ )
+ }
+
+ def verifyEnvBasedRefSecrets(launchedTasks: List[TaskInfo]): Unit = {
+ val envVars = launchedTasks.head
+ .getCommand
+ .getEnvironment
+ .getVariablesList
+ .asScala
+ assert(envVars
+ .filter(!_.getName.startsWith("SPARK_")).length == 2) //
user-defined secret env vars
+ val variableOne = envVars.filter(_.getName == "SECRET_ENV_KEY").head
+ assert(variableOne.getSecret.isInitialized)
+ assert(variableOne.getSecret.getType == Secret.Type.REFERENCE)
+ assert(variableOne.getSecret.getReference.getName == "/path/to/secret")
+ assert(variableOne.getType == Environment.Variable.Type.SECRET)
+ val variableTwo = envVars.filter(_.getName == "PASSWORD").head
+ assert(variableTwo.getSecret.isInitialized)
+ assert(variableTwo.getSecret.getType == Secret.Type.REFERENCE)
+ assert(variableTwo.getSecret.getReference.getName == "/anothersecret")
+ assert(variableTwo.getType == Environment.Variable.Type.SECRET)
+ }
+
+ def configEnvBasedValueSecrets(secretConfig: MesosSecretConfig):
Map[String, String] = {
+ val secretValues = "user,password"
+ val envKeys = "USER,PASSWORD"
+ Map(
+ secretConfig.SECRET_VALUE.key -> secretValues,
+ secretConfig.SECRET_ENVKEY.key -> envKeys
+ )
+ }
+
+ def verifyEnvBasedValueSecrets(launchedTasks: List[TaskInfo]): Unit = {
+ val envVars = launchedTasks.head
+ .getCommand
+ .getEnvironment
+ .getVariablesList
+ .asScala
+ assert(envVars
+ .filter(!_.getName.startsWith("SPARK_")).length == 2) //
user-defined secret env vars
--- End diff --
Done
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
