Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/19460#discussion_r143640733
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/BufferHolder.java
---
@@ -36,9 +37,7 @@
*/
public class BufferHolder {
- // Some JVMs can't allocate arrays of length Integer.MAX_VALUE; actual
max is somewhat
- // smaller. Be conservative and lower the cap a little.
- private static final int ARRAY_MAX = Integer.MAX_VALUE - 8;
+ private static final int ARRAY_MAX =
ByteArrayMethods.MAX_ROUNDED_ARRAY_LENGTH;
--- End diff --
Ok, these constants became redundant. No big deal. We don't need to rush
this though
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
