Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19272#discussion_r143835301
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkHadoopUtil.scala 
---
    @@ -142,6 +142,13 @@ class SparkHadoopUtil extends Logging {
         }
       }
     
    +  def addDelegationTokens(tokens: Array[Byte], sparkConf: SparkConf) {
    --- End diff --
    
    Add a comment about what this method is doing and why it's needed. (YARN 
never sets the authentication method, so it'd be good to know why Mesos needs 
to do it.)


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to