Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19316#discussion_r144034339
--- Diff:
core/src/main/scala/org/apache/spark/storage/memory/MemoryStore.scala ---
@@ -388,7 +388,13 @@ private[spark] class MemoryStore(
// perform one final call to attempt to allocate additional memory if
necessary.
if (keepUnrolling) {
serializationStream.close()
- reserveAdditionalMemoryIfNecessary()
+ if (bbos.size > unrollMemoryUsedByThisBlock) {
+ val amountToRequest = bbos.size - unrollMemoryUsedByThisBlock
--- End diff --
Why not just fix that in `reserveAdditionalMemoryIfNecessary` ?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
