Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19448#discussion_r144119701
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormat.scala
 ---
    @@ -138,6 +138,10 @@ class ParquetFileFormat
           conf.setBoolean(ParquetOutputFormat.ENABLE_JOB_SUMMARY, false)
         }
     
    +    require(!conf.getBoolean(ParquetOutputFormat.ENABLE_JOB_SUMMARY, false)
    --- End diff --
    
    `SparkException` makes it sound like it's a problem that Spark caused in 
some way. While this is caused by user input being incorrect, in which case the 
suggested `IllegalArgumentException` (which `require` throws) is better imo.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to