Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19452#discussion_r143879599 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinHelper.scala --- @@ -66,6 +67,60 @@ object StreamingSymmetricHashJoinHelper extends Logging { } } + /** + * Wrapper around various useful splits of the join condition. + * left AND right AND joined is equivalent to full. + * + * Note that left and right do not necessarily contain *all* conjuncts which satisfy + * their condition. Any conjuncts after the first nondeterministic one are treated as + * nondeterministic for purposes of the split. + * + * @param left Deterministic conjuncts which reference only the left side of the join. + * @param right Deterministic conjuncts which reference only the right side of the join. + * @param joined Conjuncts which are in neither left nor right. + * @param full The full join condition. + */ + case class JoinConditionSplitPredicates( + left: Option[Expression], --- End diff -- left -> leftSideOnly right -> rightSideOnly joined -> bothSides full
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org